search

catalyst / moodle-mod_scormremote

A Moodle activity for serving SCORM packages remotely to another LMS across domains
https://moodle.org/plugins/mod_scormremote
Other
9 stars 3 forks source link

[#44] Remove mdl_ prefix #45

Closed ScottVerbeek closed 1 year ago

ScottVerbeek commented 1 year ago

This pull request removes any mdl_ prefix from the code base the used queries. It also fixes the code style used for these queries according to https://moodledev.io/general/development/policies/codingstyle/sql

Closes #44.

brendanheywood commented 1 year ago

@ScottVerbeek can you please remove the 'AS' and then this should be good to land

ScottVerbeek commented 1 year ago

Hi @brendanheywood I've removed all FROM * AS and JOIN * AS. There is still the one line that does SELECT sc.id AS clientid.

brendanheywood commented 1 year ago

thanks!