search

catalyst / moodle-mod_subcourse

Subcourse module for Moodle
https://moodle.org/plugins/mod_subcourse
GNU General Public License v3.0
24 stars 41 forks source link

Event observers #12

Closed vadimonus closed 9 years ago

vadimonus commented 10 years ago

HI, David. I have rebased version of subcourse module with event observers on your latest master. It does not need manual grades fetching user action at all, so teachers allways see actual grades and grades, and module activity link leads directly to referenced course. Cron fetching action is needed just to иу shure, that old grades are synced, so it's configured to run once a week by default.

Please take a look.

mudrd8mz commented 10 years ago

Hi Vadim. Thanks a lot for the patch. I like the suggested functionality based on events. However, the pull request seems to contain more unrelated changes. Why are you dropping the recently added 'instantredirect' field? And why all those changes to the output?

vadimonus commented 10 years ago

Hi, David. Currently view.php is used only to show to student his grade. Student can easily see his marks in grades report, so this page is not needed for students at all. For teacher it shows link to grader report (can be easyli accessed by going trough subcourse link, than grader report, same two mouse clicks), button for fetching grades (not needed anymore, as grades are always synced) and last fetch time (not needed anymore too). In my opinion removing of this page simplify interface both for students and teachers. So all subcourses now are in instantredirect mode, so such database field is not needed anymore. But if you think this page is still neeed to show student his grade and to show teacher graderreport link, I can make another pull request without this changes

mudrd8mz commented 10 years ago

Interesting. I see your point. I was thinking about a use-case when the Subcourse description contains some important information/details about the activity. For this case, disabling the instant redirect is what the teacher may want to do. Also, I believe that editing teachers should still have an option to "view" the subcourse instance (for easy access to its setting, permission overrides and other items available in the Navigation and Admininistration blocks only when the current context is the module's one). I would prefer not to force the instant redirect. Thanks.

mudrd8mz commented 9 years ago

Event observers included in the v3.0 release of the plugin. Thanks Vadim.