search

catalyst / moodle-mod_subcourse

Subcourse module for Moodle
https://moodle.org/plugins/mod_subcourse
GNU General Public License v3.0
25 stars 41 forks source link

Subcourse completion not able to be set to passing grade #90

Closed reactor0138 closed 4 months ago

reactor0138 commented 4 months ago

Hi Dan. Seems ages. (otago Uni)

I know Our team worked with you guys to get an activity to push through as well as the final grade of a course for subcourses.

I seem to have come across an oversight/bug. I wanted the completion of the subcourse activity in a course to trigger a certificate (I know i could install a couple of plug ins for restriction but these will take time)

Anyway, I set a passing grade on the activity in the subcourse (not activity in the real course) I set it to be complete on a passing grade too, and also course completion too. I even then set a passing grade on the subcourse activity in the real course via the gradebook item.

However no matter which of the 3 passing grades (all set) it always comes back not being able to save. It jsut gives the meassge "This activity does not have a valid grade to pass set. It may be set in the Grade section of the activity settings." in red.

It works for just a grade but that does not help. It seems as though the subcourse activity either can't pick up the passing grade from the course, the passing grade from the activity or the passing grade set in the gradebook for the subcourse activity.

Could you possible look at this. Perhaps I'm missing something and it's our moodle?

Also forgot to mention that I even tried checking "Student must complete the referenced course to complete this activity." and although this saves, on the front page its says "You have to add at least one completion condition". I was hoping this just checked the and the course complete it might work but did not

subcourse completion error

reactor0138 commented 4 months ago

reference course to complete this activity no completion

danmarsden commented 4 months ago

Hi @reactor0138 - Thanks for the report! - those are actually 2 existing known issues:

65 and #86 cover those 2 issues but it's also partly mentioned in #15 as well

Unfortunately it's not something we have anyone looking into right now but feel free to reach out privately if you would like to fund some improvements (otherwise, pull requests are always welcome too!!)

thanks,

reactor0138 commented 4 months ago

Thanks Dan for taking a look. Sorry to waste your time. I'll talk to the Medmoodle team to see if they have some funds

danmarsden commented 4 months ago

no worries - the screenshots were really helpful and helped me remember what some of the open issues still are with this plugin - hope all is going well!