search

catalyst / moodle-mod_subcourse

Subcourse module for Moodle
https://moodle.org/plugins/mod_subcourse
GNU General Public License v3.0
24 stars 41 forks source link

Fix the i_add_to_section_and_i_fill_the_form_with deprecation for Moodle 4.4 #97

Open Julian-Tovar opened 1 month ago

Julian-Tovar commented 1 month ago

Good day team,

In Moodle 4.4, this Behat step was deprecated:

And I add a "Subcourse" to section "1" and I fill the form with:

This step is used on 'tests/behat/auto_fetch_grades.feature' among other files.

I attach the following patch to fix this Behat issue for Moodle 4.4. mod_subcourse_Behat_fixies_4.4.patch

Let me know if this patch is acceptable or if it contains mistakes or missing parts, and if I should create a PR with it or if you apply it on your side in that case.

Thank you.

danmarsden commented 1 month ago

Hi @Julian-Tovar - if you could send through a PR that would be great! - that way we can trigger github actions which will hopefully show the test as passing and we can merge it in

Julian-Tovar commented 1 month ago

Hi @danmarsden this is done. This is the PR: https://github.com/catalyst/moodle-mod_subcourse/pull/98 please let me know if I made a mistake or there is any missing info. Thank you.