Suggestion only - more `plagiarism_plugin_odessa` out of `lib.php`

catalyst / moodle-plagiarism_odessa

0 stars 1 forks source link

Open roperto opened 7 years ago

roperto commented 7 years ago

This would help with organising the class structure and help with coverage tests.

most files outside classes shouldn't be involved in coverage tests as they can be web urls, not really testable by phpunit (but by behat yes)

One way to achieve that is to move all the contents to classes/local/odessa.php , properly namespaced, and let lib.php inherit from that class.

suankan commented 7 years ago

File lib.php contains hooks that are hardcoded to be fired in Moodle core. Its already a moodle structural file, what can we do?