search

catalyst / moodle-plagiarism_odessa

0 stars 1 forks source link

Moodle Namespace conventions #18

Open roperto opened 7 years ago

roperto commented 7 years ago

I am not so sure about this...

Source: https://docs.moodle.org/dev/Coding_style#Namespaces

In the classes folder, I think:

suankan commented 7 years ago

observer.php should be inside events subfolder (namespace plagiarism_odessa/events)

Not necessary. In this case, we don't have too much classes/functionality so we can keep the observer class just inside of pluginname/classes/ directory. Looking into existing code of other plugins, I don't see a trend of putting observer.php somewhere strictly.

odessa_client_api.php and submissions_manager.php inside local subfolder

Why? When looking through namespaces coding style I don't see that as a requirement.

brendanheywood commented 7 years ago

https://docs.moodle.org/dev/Coding_style#Examples