search

catalyst / moodle-report_allbackups

This report allows access to all backups on a site - including those stored in all users private files
Other
6 stars 7 forks source link

Fixes #11 (File id used as user profile id) #15

Closed danowar2k closed 3 years ago

danowar2k commented 3 years ago

This would fix #11 .

Analog implementation in Moodle core: https://github.com/moodle/moodle/blob/338b60f43b25c84e684dc075ff59132a24461d32/mod/quiz/report/attemptsreport_table.php#L38

Checked locally, it uses the correct field then to generate the profile URL.

danowar2k commented 3 years ago

Original line of code in Moodle which defaults the field: https://github.com/moodle/moodle/blob/c69c33b14d9fb83ca22bde558169e36b5e1047cf/lib/tablelib.php#L134

Docs where it says that one should override the field if necessary: https://github.com/moodle/moodle/blob/c69c33b14d9fb83ca22bde558169e36b5e1047cf/lib/tablelib.php#L847-L848

danmarsden commented 3 years ago

thanks @danowar2k ! merged in.

danowar2k commented 3 years ago

Glad to help with oneliners ;-) It's all I can manage with the workload :-D