get_legacy_logdata throwing errors

catalyst / moodle-report_allbackups

This report allows access to all backups on a site - including those stored in all users private files

Other

6 stars 7 forks source link

get_legacy_logdata throwing errors #21

Open sharpchi opened 3 weeks ago

sharpchi commented 3 weeks ago

Now that MDL-80206 has been implemented, this plugin is throwing errors when debugging is turned on (always on dev sites) making it almost impossible to use in a dev/staging environment.

The events: report_viewed, autobackup_deleted, backup_deleted and report_downloaded all need the get_legacy_logdata functions to be removed.

Tested on M4.5 and PHP 8.3

sharpchi commented 2 days ago

Although I note you can set $CFG->debug_developer_debugging_as_error = false; in your config.php file. But that kinda hides the glory of whoops. Can do a pull request if you want, but it's just removing the get_legacy_logdata functions from the event.