Closed danmarsden closed 2 years ago
Note: - I'd ideally like to fix the behat tests on the main branch before we merge this so we can see it passing in both mysql and postgres.
Now that I'm thinking about that behat test... I'm tempted to add a setting in that allows it to build the cache table on page-load if not populated recently.... easier than trying to trigger a scheduled task in behat.
Looks great, minor comments in the pr, also make sure we close this one when we merge this:
https://github.com/catalyst/moodle-report_coursesize/issues/15
thanks Brendan - good to have someone elses eyes on this.
@danmarsden this looks good to me, I'll let you sort behat and merge whenever
merged manually - ended up adding a live/scheduled task setting in the end so that people can still run the report directly rather than using scheduled task - it is set to run via scheduled task by default.
This is a basic version of an async report.
I made a few decisions here that are worth documenting.
Still a lot of code that would be nice to clean up in this, but wanted to minimise the changes to just the stuff neccessary for async support.