Closed danmarsden closed 4 years ago
edit_conditions also does: global $DB, $PAGE, $SESSION; which you shouldn't need because it's not inside a class or function.
weird "global $DB" in edit_experiment.php too.. https://github.com/catalyst/moodle-tool_abconfig/blob/master/edit_experiment.php#L69
files include config.php OR use MOODLE_INTERNAL checks... your edit_conditions/edit_experiment/manage_experiment files all incude config.php so the MOODLE_INTERNAL check is redundant :-)