incorrect use of MOODLE_INTERNAL

catalyst / moodle-tool_abconfig

A way to A/B test config, or slowly turn on config for certain audiences or % of traffic

https://moodle.org/plugins/tool_abconfig

6 stars 4 forks source link

incorrect use of MOODLE_INTERNAL #29

Closed danmarsden closed 4 years ago

danmarsden commented 4 years ago

files include config.php OR use MOODLE_INTERNAL checks... your edit_conditions/edit_experiment/manage_experiment files all incude config.php so the MOODLE_INTERNAL check is redundant :-)

danmarsden commented 4 years ago

edit_conditions also does: global $DB, $PAGE, $SESSION; which you shouldn't need because it's not inside a class or function.

danmarsden commented 4 years ago

weird "global $DB" in edit_experiment.php too.. https://github.com/catalyst/moodle-tool_abconfig/blob/master/edit_experiment.php#L69