catalyst / moodle-tool_abconfig

A way to A/B test config, or slowly turn on config for certain audiences or % of traffic
https://moodle.org/plugins/tool_abconfig
6 stars 4 forks source link

4.4+: Callback before_footer in tool_abconfig component should be migrated to new hook callback for core\hook\output\before_footer_html_generation #67

Open aspark21 opened 1 month ago

aspark21 commented 1 month ago

Similar to #65 but different callback that needs migrating

core.core_renderer_test/test_before_footer_html_generation_hooked
core\core_renderer_test::test_before_footer_html_generation_hooked
Unexpected debugging() call detected.
Debugging: Callback before_footer in tool_abconfig component should be migrated to new hook callback for core\hook\output\before_footer_html_generation
* line 7475 of /lib/moodlelib.php: call to debugging()
* line 7589 of /lib/moodlelib.php: call to {closure}()
* line 71 of /lib/classes/hook/output/before_footer_html_generation.php: call to get_plugins_with_function()
* line 1503 of /lib/outputrenderers.php: call to core\hook\output\before_footer_html_generation->process_legacy_callbacks()
* line 101 of /lib/tests/core_renderer_test.php: call to core_renderer->footer()
* line 1617 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to core\core_renderer_test->test_before_footer_html_generation_hooked()
* line 1223 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
* line 72 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
* line 729 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
* line 973 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 651 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
* line 146 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->run()
* line 99 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
* line 107 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()
* line 122 of /vendor/bin/phpunit: call to include()

/var/www/html/lib/phpunit/classes/advanced_testcase.php:80