catalyst / moodle-tool_cloudmetrics

Realtime metrics for Moodle
https://moodle.org/plugins/tool_cloudmetrics
GNU General Public License v3.0
0 stars 3 forks source link

Unnecessary output while php unit testing #124

Closed dmitriim closed 2 years ago

dmitriim commented 2 years ago

Is there any good reason for outputting stuff during unit tests? Would be good to get rid of that to make tests cleaner.

2) tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test::test_execute with data set #0 ('midnight +75 minutes', array(array(4, 'midnight +20 minutes'), array(2, 'midnight +75 minutes'), array(16, 'midnight')), array('activeusers', 'newusers'))
This test printed output: Generating metric for newusers             from 18 Aug 2022, 01:00 to 18 Aug 2022, 01:15
Generated metric '0' at 18 Aug 2022, 01:15
Generating metric for activeusers          from 18 Aug 2022, 00:00 to 18 Aug 2022, 01:00
Generated metric '0' at 18 Aug 2022, 01:00

To re-run:
 vendor/bin/phpunit "tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test" admin/tool/cloudmetrics/tests/tool_cloudmetrics_collect_metrics_test.php

3) tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test::test_execute with data set #2 ('2020-03-01T00:00:00', array(array(16, '2020-02-01T00:00:00'), array(512, '2020-02-01T00:00:00'), array(4096, '2020-02-01T00:00:00')), array('activeusers', 'newusers', 'onlineusers'))
This test printed output: Generating metric for newusers             from 29 Feb 2020, 23:00 to  1 Mar 2020, 00:00
Generated metric '0' at  1 Mar 2020, 00:00
Generating metric for onlineusers          from 29 Feb 2020, 00:00 to  1 Mar 2020, 00:00
Generated metric '0' at  1 Mar 2020, 00:00
Generating metric for activeusers          from  1 Feb 2020, 00:00 to  1 Mar 2020, 00:00
Generated metric '0' at  1 Mar 2020, 00:00

To re-run:
 vendor/bin/phpunit "tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test" admin/tool/cloudmetrics/tests/tool_cloudmetrics_collect_metrics_test.php

4) tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test::test_execute with data set #3 ('2020-02-02T00:02:00', array(array(2, '2020-02-01T00:00:00'), array(512, '2020-02-01T00:00:00'), array(4096, '2020-02-01T00:00:00')), array('newusers', 'onlineusers'))
This test printed output: Generating metric for newusers             from  1 Feb 2020, 23:55 to  2 Feb 2020, 00:00
Generated metric '0' at  2 Feb 2020, 00:00
Generating metric for onlineusers          from  1 Feb 2020, 00:00 to  2 Feb 2020, 00:00
Generated metric '0' at  2 Feb 2020, 00:00

To re-run:
 vendor/bin/phpunit "tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test" admin/tool/cloudmetrics/tests/tool_cloudmetrics_collect_metrics_test.php

5) tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test::test_execute with data set #4 ('2020-02-02T00:03:00', array(array(2, null)), array('newusers'))
This test printed output: Generating metric for newusers             from  1 Feb 2020, 23:55 to  2 Feb 2020, 00:00
Generated metric '0' at  2 Feb 2020, 00:00

To re-run:
 vendor/bin/phpunit "tool_cloudmetrics\tool_cloudmetrics_collect_metrics_test" admin/tool/cloudmetrics/tests/tool_cloudmetrics_collect_metrics_test.php