search

catalyst / moodle-tool_cloudmetrics

Realtime metrics for Moodle
https://moodle.org/plugins/tool_cloudmetrics
GNU General Public License v3.0
0 stars 3 forks source link

PHP warning #161

Closed jwalits closed 1 year ago

jwalits commented 1 year ago

Warning: Declaration of cltr_cloudwatch\collector::record_metrics(array $items) should be compatible with tool_cloudmetrics\collector\base::record_metrics(array $metrics, ?progress_bar $progress = NULL) in /var/www/site/admin/tool/cloudmetrics/collector/cloudwatch/classes/collector.php on line 85

Looks like https://github.com/catalyst/moodle-tool_cloudmetrics/blob/MOODLE_35_STABLE/classes/collector/base.php#L46 was changed to add progress bar support, but https://github.com/catalyst/moodle-tool_cloudmetrics/blob/MOODLE_35_STABLE/collector/cloudwatch/classes/collector.php#L85 this class wasn't updated to support progress bar causing this warning

Not an issue on production, but throws up warnings on UAT/staging causing false alarms with monitoring.

jwalits commented 1 year ago

Looks like its a regression from this issue: https://github.com/catalyst/moodle-tool_cloudmetrics/issues/111