search

catalyst / moodle-tool_cloudmetrics

Realtime metrics for Moodle
https://moodle.org/plugins/tool_cloudmetrics
GNU General Public License v3.0
0 stars 3 forks source link

invalid lang string (db approval blocker) #163

Closed danmarsden closed 5 months ago

danmarsden commented 1 year ago

string concatentaion in the lang packs is not allowed - it causes problems for the Moodle translation tool

eg: $string['test'] = "sometext"."somemoretext"; or $string['test'] = "sometext".$string['someotheritem'];

each string must be contained within one set of quotes eg: $string['test'] = "sometext somemoretext";

For example - this is not allowed: https://github.com/catalyst/moodle-tool_cloudmetrics/blob/MOODLE_35_STABLE/collector/cloudwatch/lang/en/cltr_cloudwatch.php#L55

would be good to check if there are other cases within the subplugins and core langs.

bwalkerl commented 5 months ago

Resolved in https://github.com/catalyst/moodle-tool_cloudmetrics/pull/160