catalyst / moodle-tool_cloudmetrics

Realtime metrics for Moodle
https://moodle.org/plugins/tool_cloudmetrics
GNU General Public License v3.0
0 stars 3 forks source link

Bug: inline editables need to have a default metric frequency #45

Closed brendanheywood closed 2 years ago

brendanheywood commented 2 years ago

This will die in install as well as when settings are unset:

php admin/cli/cfg.php --component=tool_cloudmetrics --name=onlineusers_frequency --unset

Coding error detected, it must be fixed by a programmer: Options for select element must contain an option for the specified value

http://moodle.local/admin/category.php?category=tool_cloudmetrics_reports

I think each metric should declare in code what its default frequency is rather than just relying on the admin settings like before

jaypha commented 2 years ago

What should the defaults be? I currently have

    activeusers: daily
    newusers: daily
    onlineusers: 5 min
brendanheywood commented 2 years ago

Yep that sounds great