search

catalyst / moodle-tool_crawler

A moodle link crawling robot, find broken, slow and oversized links
https://moodle.org/plugins/tool_crawler
10 stars 18 forks source link

Improved UX for tabs #159

Closed cameron1729 closed 2 years ago

cameron1729 commented 2 years ago

tabs.php now only shows admin tabs when the user has the correct permission. The tabs now also append a course id so that when they are accessed via course reports, the user isn't navigated away to the system level reports.

PR for master branch here: https://github.com/catalyst/moodle-tool_crawler/pull/160

brendanheywood commented 2 years ago

This all looks good but I'm wondering if you could go one step further and align the header, eg if you look at any of the other course level reports you get the course title in the header:

image but not for crawler: image

There is also some weirdness with the reports in the dropdown chooser but I think that is a lesser concern we can ignore

cameron1729 commented 2 years ago

Thanks Brendan. I've updated the two PRs to make these reports look more consistent with other course reports. Note that this branch is slightly different to the master branch due to the navigation changes in Moodle 4.0