search

catalyst / moodle-tool_dataflows

A generic workflow and processing engine which can be configured to do a large variety of tasks.
GNU General Public License v3.0
11 stars 6 forks source link

Test timeouts on PHP 8.1 #851

Open matthewhilton opened 7 months ago

matthewhilton commented 7 months ago

I've got a strong suspicion that test timeouts we've been seeing on our CI server is a regression of https://github.com/catalyst/moodle-tool_dataflows/pull/846

You can see even the Github CI actions for any php 8.1 simply dies, e.g.:

https://github.com/catalyst/moodle-tool_dataflows/actions/runs/6700057320/job/18205330143?pr=846

image

The PR I suspect caused it because of updates to the vendor i.e. composer libraries. Maybe a library version is bugged ?

matthewhilton commented 7 months ago

Running this locally on an 8.1 site, the dataflows tests seem to install correctly and run, except I get a spam of debug output:

1) tool_dataflows\local\execution\tool_dataflows_basic_execution_test::test_direct_and_out
This test printed output: 
Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211
...
matthewhilton commented 7 months ago

Re-ran https://github.com/catalyst/moodle-tool_dataflows/pull/846 actions with debugging output, and it seemed to spam a ton of deprecated messages (as in like 20k of them) and then gets stuck running the unit tests - something like an infinite loop or just too much output - not sure.