Moodle 401 stable 853 historyfix

catalyst / moodle-tool_dataflows

A generic workflow and processing engine which can be configured to do a large variety of tasks.

GNU General Public License v3.0

10 stars 6 forks source link

Moodle 401 stable 853 historyfix #854

Closed marcghaly closed 6 months ago

marcghaly commented 7 months ago

Hi @keevan,

This PR fixes issue #853, 2 commits have been cherry-picked.

Regards,

Marc-A

marcghaly commented 7 months ago

Hi @keevan,

We are getting timeouts on ci / cd for PHP 8.1, this seems to be related with Symfony's use of the ctype_digit method, I have looked at different functions that could be used however they are not exactly similar - cf

cf : #851

If I am not mistaken the version in the project is 4.4.50 - I am not sure if there are any downsides to updating the library to something higher - it seems that Symfony 6.1 will require PHP 8.1.

Regards,

Marc-Alexandre

marcghaly commented 6 months ago

Hi @keevan, I have updated supported versions and ci setting - do we need a requirement for 35 and 400 to pass ci on this branch ?

marcghaly commented 6 months ago

Issue #853 should be resolved with latest version bump, rebased, this PR brings min php version to 7.4 for ci + readme update and supported moodle version,

Regards,

Marc-A.