catalyst / moodle-tool_dataflows

A generic workflow and processing engine which can be configured to do a large variety of tasks.
GNU General Public License v3.0
10 stars 6 forks source link

External API test fix #884 #885

Closed bwalkerl closed 4 weeks ago

bwalkerl commented 1 month ago

Closes #884

From my testing, the ways to address this was either to use core_external\external_api (4.2+ only) or require externallib.

This is most likely only an issue when this class is called from the external api test, but requiring externallib.php shouldn't cause any harm and should work for both 4.1 and 4.2+.

I believe #796 has been resolved by https://github.com/catalyst/moodle-tool_dataflows/commit/87cf066716af3ced7ec022dbb0d827afd5adfa6d so we shouldn't need #803

Side note - can we add this test to CI?