catalyst / moodle-tool_dynamic_cohorts

Moodle dynamic cohorts admin tool
https://moodle.org/plugins/tool_dynamic_cohorts
4 stars 2 forks source link

Deleted accounts appear in cohort list if related rule uses logical operator OR #102

Open bmoschr opened 2 days ago

bmoschr commented 2 days ago

How can I exclude deleted users from my rules?

dmitriim commented 2 days ago

According to this code https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/condition_manager.php#L261 deleted users should be excluded.

Are you on the latest version of the plugin? If so can you please provide steps to replicate?

bmoschr commented 2 days ago

Right now I'm using the version 2024051000 on moodle 4.1.11+ (Build: 20240614).

My steps:

and I have deactivated the setting 'release members' on the plugin setting page

bmoschr commented 2 days ago

Does the latest patch also include old rules?

dmitriim commented 2 days ago

Thanks @bmoschr! I was able to replicate this issue for a rule with logical operator OR