catalyst / moodle-tool_dynamic_cohorts

Moodle dynamic cohorts admin tool
https://moodle.org/plugins/tool_dynamic_cohorts
4 stars 2 forks source link

issue #41: add course completed and course_not_completed conditions #74

Closed dmitriim closed 3 months ago

dmitriim commented 3 months ago

This MR adds a new condition "Course completed" and "Course not completed".

To test you'd need to have courses with enabled/disabled completion and get some users to complete those courses. Then configure a rule with "Course completed" condition (ANY, BEFORE and AFTER operator) and check if matching users are same as users that completed course(s). Then you can disable completion or delete configured courses and confirm a rule becomes broken with a relevant message.

tuanngocnguyen commented 3 months ago

Looks good to me