search

catalyst / moodle-tool_dynamic_cohorts

Moodle dynamic cohorts admin tool
https://moodle.org/plugins/tool_dynamic_cohorts
4 stars 2 forks source link

Allow users with tool/dynamic_cohorts:manage access Manage rules page #76

Open dmitriim opened 3 months ago

dmitriim commented 3 months ago

The tool_dynamic_cohorts plugin ships with the tool/dynamic_cohorts:manage capability. For customer projects, I would love to be able to assign this capability to the manager role to allow managers / non-admins to configure the rules within the plugin.

Unfortunately, this does not work yet as on https://github.com/catalyst/moodle-tool_dynam ... ODLE_401_STABLE/index.php#L33, admin_externalpage_setup is used which limits the configuration page to admins only.

Can you extend the plugin in a way to allow all roles who have the tool/dynamic_cohorts:manage capability to configure the rules (in the GUI)?

dmitriim commented 3 months ago

To be properly implemented, this all needs to be a new API bit when conditions can control who can apply them as some conditions expose stuff. Like list of courses, list of cohorts and etc.

We still can do a quick fix to convert index.php from config page to a normal page with tool/dynamic_cohorts:manage capability check. However this would only work for users who already have extended permissions for other part of Moodle.

dmitriim commented 2 months ago

The interim solution has been released. Still keen to do it properly.