ah hoc task fail for a rule id that is now deleted

[MURBASLMS]

FYI noticed this, rule 32 deleted, wondered if something should be added to code to clean up once rule removed.

Execute adhoc task: tool_dynamic_cohorts\task\process_rule Adhoc task id: 26121557 Adhoc task custom data: 32 ... started 05:32:26. Current memory use 57.6 MB. Debugging increased temporarily due to faildelay of 86400 Processing dynamic cohort rules: processing rule with id 32 ... used 1 dbqueries ... used 0.0017199516296387 seconds Adhoc task failed: tool_dynamic_cohorts\task\process_rule,Argument 1 passed to tool_dynamic_cohorts\rule_manager::process_rule() must be an instance of tool_dynamic_cohorts\rule, bool given, called in /admin/tool/dynamic_cohorts/classes/task/process_rule.php on line 46 Backtrace:

• line 46 of /admin/tool/dynamic_cohorts/classes/task/process_rule.php: call to tool_dynamic_cohorts\rule_manager::process_rule()
• line 367 of /lib/cronlib.php: call to tool_dynamic_cohorts\task\process_rule->execute()
• line 198 of /lib/cronlib.php: call to cron_run_inner_adhoc_task()
• line 76 of /lib/cronlib.php: call to cron_run_adhoc_tasks()
• line 178 of /admin/cli/cron.php: call to cron_run()

[dmitriim]

Looks like you hit unlikely edge case. But fair point the code should handle that better.