Relax the security warning for gmail - Githubissues

catalyst / moodle-tool_emailutils

2 stars 2 forks source link

Relax the security warning for gmail #51

Closed brendanheywood closed 1 month ago

brendanheywood commented 1 month ago

https://github.com/catalyst/moodle-tool_emailutils/blob/MOODLE_39_STABLE/classes/check/dnspostmastertools.php#L87

[ ] Firstly if no emails go to gmail then this check doesn't matter
[ ] This has some nuance because some domains are handled by gmail but are custom domain. Not sure its work doing the mx record lookup for these - cna be bonus points
[ ] Even if all this is being used it should not be a warning, just info is ok
[ ] However if it IS half setup then it should be a warning if its done wrong

brendanheywood commented 1 month ago

So in the info section what I think we should do it:

[x] Do a group by email domain query to find the top 5 domains used by users
[x] grab the mx record for all of them
[x] if any match google then show that
[x] if none match then make the check a NA
[x] if some match then make the check an info
[x] either way if the records are half setup then warn