search

catalyst / moodle-tool_forcedcache

Moodle MUC config managed deterministicly in code using rulesets
https://moodle.org/plugins/tool_forcedcache
9 stars 9 forks source link

Codechecker issues found since #31 #32

Closed keevan closed 3 years ago

keevan commented 3 years ago

For example: https://github.com/catalyst/moodle-tool_forcedcache/runs/4161249845?check_suite_focus=true


Run moodle-plugin-ci codechecker
 RUN  Moodle Code Checker on tool_forcedcache
........E..W... 15 / 15 (100%)

FILE: /home/runner/work/moodle-tool_forcedcache/moodle-tool_forcedcache/moodle/admin/tool/forcedcache/classes/check/enabled.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
    |       | (moodle.Files.MoodleInternal.MoodleInternalGlobalState)
------------------------------------------------------------------------------------------------------------------------------------

FILE: ...ner/work/moodle-tool_forcedcache/moodle-tool_forcedcache/moodle/admin/tool/forcedcache/classes/cache_administration_helper.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 261 | WARNING | Inline comments must end in full-stops, exclamation marks, or question marks
     |         | (moodle.Commenting.InlineComment.InvalidEndChar)
------------------------------------------------------------------------------------------------------------------------------------

Time: 1.37 secs; Memory: 18MB

Error: Process completed with exit code 1.