search

catalyst / moodle-tool_mfa

A Multi-Factor Authentication Moodle plugin with flexible support for TOTP, Email, IP and more
https://moodle.org/plugins/tool_mfa
35 stars 38 forks source link

Check nosetup factor correctly so that menu displays. #417

Closed danmarsden closed 1 year ago

danmarsden commented 1 year ago

Fix #330 Fix #391

danmarsden commented 1 year ago

@Peterburnett can you please take a look at this one? - I think this is the right way to fix #330 #391 instead of the method used in #382

Peterburnett commented 1 year ago

So my only concern here is this removes the use case where you want only a certain cohort of users to be able to use MFA. Eg administrators etc. The intent of the splitting is that you don't see the menu if you would be awarded points and able to authenticate. I agree that it is causing more headaches for some users than it might be worth...

Peterburnett commented 1 year ago

Hmm looks like I already thought about this a while ago and mentioned it in #382. I think this is good to go. Benefit outweighs the drawbacks.

danmarsden commented 1 year ago

thanks - backported to 35_STABLE branch too.