Totara 18 now includes paragonIE used in totp factor.

catalyst / moodle-tool_mfa

A Multi-Factor Authentication Moodle plugin with flexible support for TOTP, Email, IP and more

33 stars 38 forks source link

Totara 18 now includes paragonIE used in totp factor. #437

Closed danmarsden closed 12 months ago

danmarsden commented 12 months ago

Totara 18 (TL-37451) added the paragonIE constant_time_encoding stuff which now conflicts with the totp factor - we probably need to create a new TOTARA_18 branch and remove the external lib.

aneno-m-e commented 12 months ago

I just pushed a new TOTARA_18_STABLE branch.

checked out from the TOTARA_12 branch
added a commit to switch to using the core library for ParagonIE

danmarsden commented 12 months ago

Thanks @aneno-m-e I've just renamed that branch to "TOTARA_18" - removing the stable text and dropped a patch into the readme on all branches mentioning the new branch.

Do you know if the patches mentioned in the readme are still needed on the Totara_18 branch? - also might be worth checking the requires version in teh version.php file to see if we can bump it higher to make it clear Totara 18 is required?

thanks!

aneno-m-e commented 12 months ago

I've updated the require version as the library does not exist in earlier versions of Tōtara.

The patches are still required . If #373 is merged, it could be used on this branch as well. A watcher has not been added to Tōtara core yet.

danmarsden commented 12 months ago

Thanks!