search

catalyst / moodle-tool_mfa

A Multi-Factor Authentication Moodle plugin with flexible support for TOTP, Email, IP and more
https://moodle.org/plugins/tool_mfa
34 stars 38 forks source link

Closes #450. Fixed cohort factor list. #452

Open haiksu opened 10 months ago

haiksu commented 10 months ago

Instead of using cohort_get_all_cohorts() method, which returns only 25 cohorts, this modification fetches all the cohorts straight from the database without limitations.

danmarsden commented 1 month ago

Thanks @haiksu - please note that as this plugin is now part of Moodle core - we need to address any issues/bugs/improvements in the upstream "latest" release before we backport to this repository to support older Moodle sites. I note the current Moodle upstream release has the same "older" code: https://github.com/moodle/moodle/blob/main/admin/tool/mfa/factor/cohort/settings.php#L41

If you end up creating an upstream Moodle tracker for this and fixing it there - please come back and post the details here so we can then look at merging this into the repo here for older sites - otherwise we need to close this as "won't fix."