search

catalyst / moodle-tool_objectfs

Object file storage system for Moodle
https://moodle.org/plugins/tool_objectfs
88 stars 72 forks source link

issue #472: check if s3 client configured before using it #473

Closed dmitriim closed 2 years ago

keevan commented 2 years ago

It probably wouldn't hurt to also add a simple test to ensure it doesn't explode, e.g. if the connection was not set up fully.

dmitriim commented 2 years ago

any idea on where to add this test?

keevan commented 2 years ago

any idea on where to add this test?

Perhaps here? admin/tool/objectfs/tests/classes/test_s3_integration_client.php

dmitriim commented 2 years ago

added tests. They actually helped to find a bug in is_configured for s3