search

catalyst / moodle-tool_objectfs

Object file storage system for Moodle
https://moodle.org/plugins/tool_objectfs
88 stars 72 forks source link

Moodle 310 stable add commits from master #487

Closed tuanngocnguyen closed 2 years ago

tuanngocnguyen commented 2 years ago

The M310 branch has is_whitelisted function removed as compared to master branch I have merged the commit from master branch and made changes on Readme file regards supported versions

danmarsden commented 2 years ago

do we even need the MOODLE_310_STABLE branch? - the master branch currently supports 3.4 and higher versions... so under our naming conventions (unless there's a reason to branch) if we want to stop using the "master" named branch, we should create a new MOODLE_34_STABLE branch

tuanngocnguyen commented 2 years ago

Hi @danmarsden ,

The M310 applied your suggestion:

https://github.com/catalyst/moodle-tool_objectfs/commit/453c693cbdae82509c92130107e31ea484e47e9b

So I think we need a separate branch for M10+

tuanngocnguyen commented 2 years ago

@danmarsden Changes in M10: https://github.com/catalyst/moodle-tool_objectfs/blob/MOODLE_310_STABLE/classes/local/manager.php#L245 is_whitelisted has been removed

tuanngocnguyen commented 2 years ago

There will be branch for M3.3 cloned from master

danmarsden commented 2 years ago

I guess that's a good enough reason as any to create a new branch... :-)

brendanheywood commented 2 years ago

@danmarsden for context this work is all about realigning to the new branch name strategy and deprecating master, see:

https://wrms.catalyst.net.nz/wr.php?request_id=383792

danmarsden commented 2 years ago

Thanks- was really just a "why 3.10" seems like a weird release to choose as a branching point.