search

catalyst / moodle-tool_objectfs

Object file storage system for Moodle
https://moodle.org/plugins/tool_objectfs
88 stars 72 forks source link

issue505 Do not include objects in population task lookup that are orphaned or errors #520

Closed andrewmadden closed 1 year ago

danmarsden commented 1 year ago

@andrewmadden is this waiting in the queue for any good reason? - I've just had a site showing this task running really slow and this seems to drop the number of records it's dealing with by 25% so I'd be keen to merge it unless you have any objections?

danmarsden commented 1 year ago

merged this in and dropped a change on top to use a join instead of a left join. - When the number of orphaned records is higher than 100,000 (returning a null filesize) - this ad-hoc task never ends, - it runs on the first 100,000 records, then spawns another ad-hoc task and does the same thing all over again....

andrewmadden commented 1 year ago

merged this in and dropped a change on top to use a join instead of a left join. - When the number of orphaned records is higher than 100,000 (returning a null filesize) - this ad-hoc task never ends, - it runs on the first 100,000 records, then spawns another ad-hoc task and does the same thing all over again....

@danmarsden Sorry for delay. This was a forward port of https://github.com/catalyst/moodle-tool_objectfs/pull/518 that was merged a few months ago. Looks like it slipped under the radar after we checked the performance bug was fixed in the 33 branch. Thanks for pushing it along.

The branches will be slightly out of sync with your change to the SQL but I don't think it will be an issue.