Cleanup all coding standards and phpdoc warnings. Mostly done via phpcbf + manually converting unit test providers to static functions (after confirming they are truly static, just weren't labelled as such)
Removed legacy privacy api polyfill needed because older php versions didn't support typehinting, however, Moodle 3.10 supports Php 7.2 which supports type hinting (params and return types)
To Do
[x] Test utf8_encode replacement and confirm it still works as expected
Changes
phpcbf+ manually converting unit test providers to static functions (after confirming they are truly static, just weren't labelled as such)utf_encode- cherry picked commit from here https://github.com/catalyst/moodle-tool_objectfs/pull/598 - tested in S3 myself, and S3 + cloudfront in the other PR and works as expected, seems equivalent.To Do
utf8_encodereplacement and confirm it still works as expected