search

catalyst / moodle-tool_trigger

Like IFTTT for Moodle: events to trigger external services. https://moodle.org/plugins/tool_trigger
Other
42 stars 27 forks source link

Issue#203 Insert tool_trigger_events id into event other data #205

Closed tuanngocnguyen closed 1 year ago

tuanngocnguyen commented 1 year ago

issue https://github.com/catalyst/moodle-tool_trigger/issues/203

Testing Instruction

The purpose of this test is to check if the ID is available only (I am not sure about its usage)

  1. Go to Site Admin > Plugins > Admin Tools > Event Trigger > Manage: https://{moodle_site}/admin/tool/trigger/manage.php
  2. Add new trigger workflow
  3. Enter a name
  4. Choose a Event to monitor. Suggested: Core: User Login Failed
  5. Enable "Real Time Processing"
  6. Click on "Add work flow step"
  7. Choose step type: look up
  8. Choose step: user lookup
  9. Enter name
  10. Enter description
  11. Enter "id" in "User id data field "
  12. Save the step
  13. Save the work flow

Before applying the patch

  1. Open another browser
  2. Try login with non-existing user name/password
  3. There will be an error shows that the ID field is invalid (Specified userid field not present in the workflow data: id)

Applying the patch

  1. Perform the login again
  2. There is no error regards the field ID (we may get non-existing user error as we use event id to find user)
dmitriim commented 1 year ago

Hi @tuanngocnguyen! Thanks for working on that patch. Can you please add some instruction for manual testing?

tuanngocnguyen commented 1 year ago

Hi @dmitriim ,

I have added testing instruction