Rename http_post_action_step to just http_action_step - Githubissues

catalyst / moodle-tool_trigger

Like IFTTT for Moodle: events to trigger external services. https://moodle.org/plugins/tool_trigger

Other

42 stars 27 forks source link

Rename http_post_action_step to just http_action_step #209

Closed dmitriim closed 1 year ago

dmitriim commented 1 year ago

Currently http_post_action_step supports POST method only, however in some cases we would likt to send GET/PATCH/PUT and etc

We can rename http_post_action_step to just http_action_step and add an extra option for choosing http method.

[x] modify existing http_post_action_step and add a new dropdown option "Method" with otions like POST, GET, PUT, DELETE, PATCH
[ ] rename http_post_action_step to http_action_step
[ ] upgrade script that will update tool_trigger_steps and tool_trigger_run_hist tables with a new class name and setting

dmitriim commented 1 year ago

I think it's ok to leave http_post_action_step as is having in mind that the plugin will be retired soon anyways.