search

catalyst / moodle-tool_webanalytics

A Moodle admin tool adding Web Analytics to your Moodle site.
https://moodle.org/plugins/tool_webanalytics
7 stars 11 forks source link

track_only_students and categories added to admin settings #37

Open piccard21 opened 3 years ago

piccard21 commented 3 years ago

In big installations, like universities have for example, it isn't always wanted to track everything and everybody, One thing is the heavy load you get on the server, the other one is the flood of unnecassary data you normally don't wanna have. In our university for example, it was wanted to track just certain categories and also only students, who are visiting a course. So I added these two options in your admin settings. Maybe you find it useful and want to add it. Sorry for not having added tests to it:-(

dmitriim commented 3 years ago

hi @piccard21 Thank you for the pull request. Before we can properly have a look at it can you please clean up your changes:

  1. revert permission chnages
  2. revert changes to all classes like https://github.com/catalyst/moodle-tool_webanalytics/pull/37/files#diff-cb9efb0b962f082e097ea922ad4e08b1f1dd6e3626de2094ddd93f932525f734R40

After that it will be ready for review. Cheers!