Totara 11.22 and manager sign-off

catalyst / totara-mod-ojt

https://github.com/catalyst/totara-mod-ojt/wiki

5 stars 21 forks source link

Totara 11.22 and manager sign-off #22

Open johannavehkanen opened 4 years ago

johannavehkanen commented 4 years ago

Hi,

this from Totara forums "It seems that staff can fully complete themselves - even when Manager Sign Off is turned on, and the completion criteria requires all sign offs to be undertaken. "

I found the same to be true when using Totara version 11.22: the OJT activity is marked as completed without the manager approval/sign-off. Any experiences with this?

Best, Johanna Vehkanen, Discendum, Totara partner

iaincamerononeill commented 3 years ago

Can confirm on Totara 12.

michaelkotlyar commented 2 years ago

Hi, I made a PR for this issue

valquimno commented 1 year ago

In addition, when manager signs off a topic it's not recorded as Complete when a witness hasn't ticked off. We have a client request that requires a once-off manager sign-off after an f2f ojt event/activity. Is it the expected behaviour that manager can sign it off even if student and witness hasn't ticked any item from their end? If not, then manager sign-off checkbox must be disabled if items aren't complete yet.