search

catalyst / totara-mod-ojt

https://github.com/catalyst/totara-mod-ojt/wiki
5 stars 21 forks source link

mod/ojt Fixes fields named comment in database tables #5

Closed catalystfd closed 7 years ago

catalystfd commented 7 years ago

This is a reserved word in oracle's db so fails moodle tests, the comment field in ojt topic signoff appeared unused, so I've removed it, meanwhile the completion comment field was renamed to complcomment and updated everywhere in the code it was referenced.

danmarsden commented 7 years ago

Looks like you missed the change in backup stepslib. You should also add some code to restore code to pull through old comment filed into the new one.

danmarsden commented 7 years ago

Also - Shouldn't it go into master and t9 before the t29 branch?