search

catalystneuro / buzsaki-lab-to-nwb

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

GrosmarkAD conversion script and class #20

Closed CodyCBakerPhD closed 3 years ago

CodyCBakerPhD commented 3 years ago

@bendichter This is the main script and converter class for the GrosmarkAD dataset. Let me know of any style and design changes beyond what we've discussed.

As mentioned, this will be the last Buzsaki conversion prior to utilizing the individual DataInterfaces to handle metadata fetching, a change that will greatly sparsify the get_metadata() function from converter classes such as this. It will also be the last dataset to use the NoRecording interface in lieu of the SortingExtractor handling electrode table metadata in the absence of a RecordingExtractor.

bendichter commented 3 years ago

It looks like this would work, but I agree ideally much of the code that is in GrosmarkNWBConverter.get_metadata would be moved to dedicated DataInterfaces. I don't really like there being data fields in the metadata dict.