search

catalystneuro / buzsaki-lab-to-nwb

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Added check for empty units #44

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

Short PR to add a check for empty units in the behavioral interface. This is because the spatial series in pynwb expects string by default and produces an assertion error with the None type.

CodyCBakerPhD commented 2 years ago

@h-mayorquin can you include the re-nesting of orientation here too?

CodyCBakerPhD commented 2 years ago

@h-mayorquin And maybe an explicitly set description for the error_per_marker field?

CodyCBakerPhD commented 2 years ago

And also append "_task" to the position series name; i.e., linear -> linear_task

h-mayorquin commented 2 years ago

I added track to the analysis and nested the orientation also added a different description more in line with the methods of the paper.

What I could not find and I am out of ideas is what description add to the Error.

CodyCBakerPhD commented 2 years ago

@h-mayorquin Could always send one last email to Tingley himself to see what he would describe that field as. Thanks for staying up late to get this finished!

CodyCBakerPhD commented 2 years ago

Per Tingley's response: description="Estimated error for marker tracking from optitrack system."

CodyCBakerPhD commented 2 years ago

@h-mayorquin LGTM; merging when tests are done, then we should be ready for final conversion. Were you still getting errors with parfor?