search

catalystneuro / dandi_s3_log_parser

S3 log parsing for the DANDI Archive.
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Fix next bad line parsing #25

Closed CodyCBakerPhD closed 3 months ago

CodyCBakerPhD commented 3 months ago

I think the previous fix in #24 should actually apply here, even though these other lines are not deviant (they seem like good requests) they just have some very unexpected extra stuff related to the 'source' of the request

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.97%. Comparing base (b86d789) to head (23fdeb6). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25/graphs/tree.svg?width=650&height=150&src=pr&token=RIT59WJokn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================== + Coverage 60.23% 67.97% +7.73% ========================================== Files 9 11 +2 Lines 337 459 +122 ========================================== + Hits 203 312 +109 - Misses 134 147 +13 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `67.97% <100.00%> (+7.73%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [src/dandi\_s3\_log\_parser/\_s3\_log\_line\_parser.py](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25?src=pr&el=tree&filepath=src%2Fdandi_s3_log_parser%2F_s3_log_line_parser.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL2RhbmRpX3MzX2xvZ19wYXJzZXIvX3MzX2xvZ19saW5lX3BhcnNlci5weQ==) | `81.17% <100.00%> (+9.99%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/catalystneuro/dandi_s3_log_parser/pull/25/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)