search

catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

removed redundant names #16

Closed pauladkisson closed 1 year ago

pauladkisson commented 1 year ago

Fixes #15

pauladkisson commented 1 year ago

Ok, so, I switched over to relative imports, but then running convert_session.py as a script broke, Traceback:

ImportError: attempted relative import with no known parent package

So as I see it we could either, 1) Move all scripts (like convert_session.py) outside of the src directory -- maybe to a dedicated scripts directory 2) Leave absolute imports in scripts like convert_session.py

Based on buszaki-lab-to-nwb seems like the latter is preferred.

CodyCBakerPhD commented 1 year ago

Ok, so, I switched over to relative imports, but then running convert_session.py as a script broke, Traceback:

Yep, that is to be expected - I should have mentioned that is the one exception since it's not actually a part of the module structure. I'll leave it up to you if you still want it in src, but point being it's a script not an imported file