search

catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

Labeled events #23

Closed pauladkisson closed 1 year ago

pauladkisson commented 1 year ago

Fixes #13

pauladkisson commented 1 year ago

Might want to move syllables to their own interface, since they get added as acquisition rather than in the behavior processing module. OTH, they are behavioral syllables. @CodyCBakerPhD lmk what you think.

CodyCBakerPhD commented 1 year ago

Might want to move syllables to their own interface

Up to you - I always personally prefer things to be as modular as possible

Can you share an example file with this events data type?

pauladkisson commented 1 year ago

Up to you - I always personally prefer things to be as modular as possible

Yeah, I think it's probably the right call here.

Can you share an example file with this events data type?

Done!

CodyCBakerPhD commented 1 year ago

Looks good overall

Only thing I wonder, is it possible (as in, does ndx-events allow it?) to cast the integer syllable_indices field as np.uint8 instead of np.uint64? Would save 8x space before compression

pauladkisson commented 1 year ago

Might want to move syllables to their own interface, since they get added as acquisition rather than in the behavior processing module.

Done,

Only thing I wonder, is it possible (as in, does ndx-events allow it?) to cast the integer syllable_indices field as np.uint8 instead of np.uint64?

and done,

Can you share an example file with this events data type?

and resent!

CodyCBakerPhD commented 1 year ago

The file using ndx-events looks great!