search

catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

Test PR bot with harmless README change #24

Closed pauladkisson closed 1 year ago

pauladkisson commented 1 year ago

This PR is to test whether using branches on the main repo (instead of from my fork) will fix the PR bot issue (see #21)

pauladkisson commented 1 year ago

Looks like this works, but I'm not sure it's worth it. I like working from my fork for full autonomy and keeping the main repo from branch clutter...tbh I don't mind adding PRs manually to my dashboard -- the biggest issue is that it flags as failing with the CI (which makes it impossible to tell at a glance whether or not it is actually failing). Lmk what you think @CodyCBakerPhD

CodyCBakerPhD commented 1 year ago

tbh I don't mind adding PRs manually to my dashboard

As long as you can keep up with it - automation is usually the most efficient way though

I like working from my fork for full autonomy

Not sure I understand - what can you do on your personal fork that you can't do anywhere else?

keeping the main repo from branch clutter

Branches clean up on merge these days; any clutter would also be on your own fork as opposed to centralized to the main org, so it's still the same total number of branches spread across GitHub

the biggest issue is that it flags as failing with the CI

Hence why it's not a requirement for merging; if we made the other CI run on PR push then even the little red X would disappear after subsequent commits

I have always wished though that there is a yellow sign status for actions in between passing and failing