catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

Optogenetic DataInterface #27

Closed pauladkisson closed 1 year ago

pauladkisson commented 1 year ago

Fixes #26

pauladkisson commented 1 year ago

Ok, I think this is a working solution. Note, currently, this DataInterface doesn't deal with the 3s-pulsed 25Hz stim experiments, but I want to do a deep dive into the relevant parquet file for those experiments first to make sure I'm not missing anything, so I think I can add that functionality in a subsequent PR.

CodyCBakerPhD commented 1 year ago

The ogen file looks great! Last minor thing regarding the name of the ogen device, but with that simple fix this should be good to go

CodyCBakerPhD commented 1 year ago

Quite a few merge conflicts now as well - I started to fix them but then realized I might not know how to do all of them so I'll let you do it to ensure I don't unintentionally break anything

Ping me again when this is ready for merge and I'll take another look

pauladkisson commented 1 year ago

@CodyCBakerPhD, merge conflicts have been resolved, so this should be ready to go.