search

catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

Support for the rest of experiment_types in optoda_raw_data/closed_loop_behavior.parquet #40

Closed pauladkisson closed 1 year ago

pauladkisson commented 1 year ago

Fixes #39. Branches from #38 --> merge that first.

CodyCBakerPhD commented 1 year ago

Fixes https://github.com/catalystneuro/datta-lab-to-nwb/issues/39. Branches from https://github.com/catalystneuro/datta-lab-to-nwb/pull/38 --> merge that first.

Can you change the head then and that makes it more obvious + better changelog?

pauladkisson commented 1 year ago

Fixes #39. Branches from #38 --> merge that first.

Can you change the head then and that makes it more obvious + better changelog?

Ooh...I don't think I can do that since all the branches except for main are in my fork...good to know for next time.

CodyCBakerPhD commented 1 year ago

Ooh...I don't think I can do that since all the branches except for main are in my fork...good to know for next time.

Yeah, yet another reason it's better for teammates to work on the same mono repo instead of forking. Technically you could make this a PR to your own fork but then it would only show up as a PR within your fork

pauladkisson commented 1 year ago

Yeah, yet another reason it's better for teammates to work on the same mono repo instead of forking.

Yep, going to use that strategy going forward.

Changelog & commit history are clean now, so this PR is ready for review.

CodyCBakerPhD commented 1 year ago

Looks interesting, do you have some example files you could share with these new ogen outputs?

CodyCBakerPhD commented 1 year ago

Will need to see the full non-stub files to be sure, but letting this through for now

We're also reaching the point where you can just post example files to the DANDI set for review (especially so for the non-stub files)