search

catalystneuro / datta-lab-to-nwb

MIT License
1 stars 2 forks source link

Keypoint Conversion #85

Closed pauladkisson closed 9 months ago

pauladkisson commented 9 months ago

Adds support for keypoint data with associated raw photometry and IR videos.

CodyCBakerPhD commented 9 months ago

Small comment on convention above

Otherwise code seems fine

Let me know when an example file is ready for perusal

pauladkisson commented 9 months ago

Let me know when an example file is ready for perusal

example file is uploaded!

CodyCBakerPhD commented 9 months ago

example file is uploaded!

Can you point me to a particular example file there for this PR?

pauladkisson commented 9 months ago

Can you point me to a particular example file there for this PR?

keypoint-dls-dlight-9

CodyCBakerPhD commented 9 months ago

Thanks

A lot of the keypoints have spaces in the names, which for programmatic access to the dictionaries is not recommended; can you pragmatically replaces spaces with underscores? This would also make it more similar to other keypoint trackers like SLEAP and DLC

CodyCBakerPhD commented 9 months ago

Otherwise the dataset contents all look good for pose estimation work

pauladkisson commented 9 months ago

A lot of the keypoints have spaces in the names, which for programmatic access to the dictionaries is not recommended; can you pragmatically replaces spaces with underscores? This would also make it more similar to other keypoint trackers like SLEAP and DLC

Done! And see updated example file: keypoint-dls-dlight-9.nwb.