search

catalystneuro / dombeck-lab-to-nwb

NWB Conversion project for the Dombeck lab at Northwestern University.
MIT License
0 stars 0 forks source link

Improvements #27

Closed weiglszonja closed 4 weeks ago

weiglszonja commented 1 month ago 
          Just a minor comment: I don't think you need to specify Green in the `FiberPhotometryResponseSeries` name. Since they are all Green. And I would store only two series `FiberPhotometryResponseSeriesSignal` and the `FiberPhotometryResponseSeriesIsobestic` both of them having the Fiber1 and Fiber2 signal. But we could change this in a follow-up PR after  mid-way meeting

Originally posted by @alessandratrapani in https://github.com/catalystneuro/dombeck-lab-to-nwb/pull/24#pullrequestreview-2073773608

weiglszonja commented 1 month ago

Also fix the unit to "n.a."