search

catalystneuro / ecogVIS

Time series visualizer and data processing tools for Electrocorticography (ECoG) signals stored in NWB files, for Python.
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

Copying of changlab_to_nwb code into this repo #91

Closed jessierliu closed 4 years ago

jessierliu commented 4 years ago

@luiztauffer I see that on the htk_loader branch, some of the code that I gave you guys is copied in here. Some of that might be confusing because a lot of it is outdated or is specific to our private changlab_to_nwb repo (so it's code that won't even run).

For example, ecogvis.functions.tdt_to_nwb.chang2nwb hosts a lot of outdated code but also the updated electrodes table function. I think it would be best to remove everything that is not being used and create a specific file to contain functions that are being used like elecs_to_electrode_table.

luiztauffer commented 4 years ago

Hi @jrliu95, I was refraining from removing anything that wasn't being substituted by my own version, since I don't know how much of that you guys might end up using in the future, so I thought of leaving as reference But I agree with you, all that unused code might confuse more than help. I'll clean it up

luiztauffer commented 4 years ago

much cleaner now!

jessierliu commented 4 years ago

Looks much better, thanks!