search

catalystneuro / ndx-microscopy

An enhancement to core NWB schema types related to microscopy data.
MIT License
0 stars 0 forks source link

[Enhancement I] Add multichannel volume #13

Closed CodyCBakerPhD closed 3 months ago

CodyCBakerPhD commented 4 months ago

This pretty much completes the absorption of relevant parts of ndx-multichannel-volume into our microscopy metadata structure, with the exception we want to avoid of the 5D time + volume + channels object, which we can include in a follow-up if desired

CodyCBakerPhD commented 3 months ago

@rly WDYT? Good to merge to get this chain moving?

CodyCBakerPhD commented 3 months ago

@alessandratrapani Any thoughts?

rly commented 3 months ago

Looks good to me. I suggested adding dims and shape to light_sources and optical_channels to enforce the 1D list nature of the underlying VectorData which can be multidimensional.

CodyCBakerPhD commented 3 months ago

@rly OK, added dim/shape