catalystneuro / ndx-patterned-ogen

patterned (holographic) optogenetic extension to NWB standard
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Should stimulation_wavelength of LightSource match the excitation_lambda of PatternedOptogeneticStimulusSite? #11

Closed CodyCBakerPhD closed 7 months ago

CodyCBakerPhD commented 7 months ago

@alessandratrapani Should the stimulation_wavelength of a LightSource always match the excitation_lambda of a PatternedOptogeneticStimulusSite?

I know the latter inherits the field from its parent - is there any way to exclude that, or is removing that field simply a 'to-do' item when these are integrated into core?

If so, do we have a list started somewhere highlighting all the changes we would make it the inheritance were refactored at the higher levels (similar to ndx-microscopy)?

alessandratrapani commented 7 months ago

Should the stimulation_wavelength of a LightSource always match the excitation_lambda of a PatternedOptogeneticStimulusSite?

Yes

I know the latter inherits the field from its parent - is there any way to exclude that, or is removing that field simply a 'to-do' item when these are integrated into core?

Yes, similarly to ndx-microscopy. Note that LightSource will be a neurodatatype shared by ndx-microscopy and ndx-patterned-ogen.

If so, do we have a list started somewhere highlighting all the changes we would make it the inheritance were refactored at the higher levels (similar to ndx-microscopy)?

Good point, I opened an issue here specifically for this: #12